Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1536] Add check to verify deprecated envar message #1423

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented Nov 5, 2024

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@danmyway danmyway added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. kind/tests Improvement or enhancement of the tests labels Nov 5, 2024
@danmyway danmyway requested a review from a team as a code owner November 5, 2024 14:06
@danmyway danmyway marked this pull request as draft November 5, 2024 14:06
@has-bot
Copy link
Member

has-bot commented Nov 5, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (822a2d2) to head (85aae3e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          72       72           
  Lines        5177     5177           
  Branches      896      896           
=======================================
  Hits         4976     4976           
  Misses        119      119           
  Partials       82       82           
Flag Coverage Δ
centos-linux-7 91.63% <ø> (ø)
centos-linux-8 92.49% <ø> (ø)
centos-linux-9 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danmyway
Copy link
Member Author

danmyway commented Nov 5, 2024

/packit test

@danmyway
Copy link
Member Author

danmyway commented Nov 5, 2024

/packit test --labels sanity

@danmyway
Copy link
Member Author

danmyway commented Nov 5, 2024

/packit test --labels sanity

@danmyway
Copy link
Member Author

danmyway commented Nov 7, 2024

/packit test --labels sanity

@danmyway
Copy link
Member Author

danmyway commented Nov 8, 2024

/packit test --labels sanity

@danmyway
Copy link
Member Author

danmyway commented Nov 8, 2024

/packit test --labels sanity

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

@danmyway danmyway marked this pull request as ready for review November 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tests Improvement or enhancement of the tests skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants